periodic: add timeout to all function calls in the tests #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karampok
force-pushed
the
pub-fix-periodic
branch
2 times, most recently
from
1c0e9a1
to
01775ac
Compare
There is a flake in periodic tests. In this commit we put the close(done) in the defer so we make sure always is executed (in case there is a return earlier). Also we guard with a timeout wrapper all functions that can be blocked.
karampok
force-pushed
the
pub-fix-periodic
branch
from
01775ac
to
8338997
Compare
lukedirtwalker
requested changes
Nov 4, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karampok)
a discussion (no related file):
the title should not state it fixes it. I'm pretty sure it doesn't.
karampok
changed the title
karampok
changed the title
lukedirtwalker
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a flake in periodic tests. In this commit
we put the close(done) in the defer so we make sure
always is executed (in case there is a return earlier).
Also we guard with a timeout wrapper all functions that
can be blocked.
This change is