Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snet: remove goconvey #3350

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Nov 8, 2019

Contributes #3016


This change is Reviewable

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @karampok)


go/lib/snet/addr_test.go, line 44 at r1 (raw file):

		{address: &Addr{IA: ia, Host: host6}, result: "1-ff00:0:320,[2001::1]:20000"},
	}
	t.Run("Method String", func(t *testing.T) {

drop


go/lib/snet/addr_test.go, line 108 at r1 (raw file):

		},
	}
	t.Run("Function AddrFromString", func(t *testing.T) {

drop

Copy link
Contributor Author

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @oncilla)


go/lib/snet/addr_test.go, line 44 at r1 (raw file):

Previously, Oncilla wrote…

drop

Done.


go/lib/snet/addr_test.go, line 108 at r1 (raw file):

Previously, Oncilla wrote…

drop

Done.

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok merged commit cb21f47 into scionproto:master Nov 11, 2019
@karampok karampok deleted the pub-snet-remove-convey branch November 14, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants