Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: Use --stamp command line flag #3380

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Bazel: Use --stamp command line flag #3380

merged 1 commit into from
Nov 14, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Nov 14, 2019

This fixes the problem introduced by new version of go_rules,
the symptom being that StartupVersion was not set properly.


This change is Reviewable

This fixes the problem introduced by new version of go_rules,
the symptom being that StartupVersion was not set properly.
Copy link
Contributor

@sgmonroy sgmonroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sgmonroy sgmonroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit 76e37e6 into scionproto:master Nov 14, 2019
@sustrik sustrik deleted the stamp branch November 14, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants