TrustStore: unify interface #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce TRCID and use ChainID and TRCID consistently in trust package. Use value types for simple structs instead of pointers. Fixes scionproto#3525
oncilla
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
Reviewed 22 of 22 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
oncilla
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce TRCID and use ChainID and TRCID consistently in trust package.
Use value types for simple structs instead of pointers.
Fixes #3525
This change is