CI: Remove explicit scionproto2 references

[lukedirtwalker]

This will allow us to rename the pipeline.

Contributes #3574

---

This change is 

[karampok]

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @karampok and @lukedirtwalker)

---

.buildkite/hooks/pre-command, line 24 at r1 (raw file):

# definition.
if [ "$BUILDKITE_PIPELINE_SLUG" == "scionproto2" ]; then
    export ACCEPTANCE_ARTIFACTS="$TEST_ARTIFACTS"

this line should not stay?

[lukedirtwalker]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @karampok)

---

.buildkite/hooks/pre-command, line 24 at r1 (raw file):

Previously, karampok (Konstantinos) wrote…

this line should not stay?

Done. Good catch!

[karampok]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved