Monolithic Control Service

[scrye]

Also:

• Micro service support was removed from the topology generator;
• In monolith, beacons are now written to path db directly instead of
  through intra-AS RPCs;
• In monolith, routing is done directly on top of the path database,
  instead of going through SCIOND;
• Move SCIOND Host API to TCP; this allows SCIOND to run on a
  different machine;
• The sd.Reliable, sd.Unix, sd.SocketFileMode, sd.DeleteSocket, and
  sd.Public SCIOND config options have been removed. Current or later
  SCIOND implementations will ignore these fields if they are set.
• The sd.address config option has been changed. It now also specifies
  the TCP address of the SCIOND Host API.
• SCIOND no longer creates socket folders (e.g., in /run/shm) when
  running.
• Automatically finding a local-machine SCIOND depending on AS number is
  no longer possible. This was used by a few tests and that run multiple
  ASes on the same machine. It is now required to specify which SCIOND to
  use.
• The topology generator generates a file containing the list of SCIONDs
  for every AS in ./sciond_addresses.toml. This is used by some tests to
  find the SCIOND servers.
• pingpong, scmp, showpaths: scionFromIA command line flag removed;
  sciond command line flag reworked to point to the TCP address of SCIOND.
• SCIOND now talks to the monolith over TCP instead of QUIC;

---

This change is 

[lukedirtwalker]

Reviewed 158 of 158 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @scrye)

---

go/cs/BUILD.bazel, line 67 at r1 (raw file):

filegroup(
    name = "schema",
    srcs = ["schema.sql"],

Removen

---

go/cs/schema.sql, line 1 at r1 (raw file):

--- contains the schema for the control plane service.

remove

---

go/lib/pathstorage/pathstorage.go, line 96 at r1 (raw file):

	}
	if err := cfg.validateConnection(); err != nil {
		return err

why is that removed?

---

acceptance/topo_cs_reload/BUILD.bazel, line 70 at r1 (raw file):

)

# Unfortunately this can't be directly used in the cs docker container above,

This comment is wrong...

[scrye]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker)

---

go/cs/BUILD.bazel, line 67 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Removen

Done.

---

go/cs/schema.sql, line 1 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

remove

Done.

---

go/lib/pathstorage/pathstorage.go, line 96 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

why is that removed?

Done.

[lukedirtwalker]

Reviewed 4 of 4 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)

---

go/cs/BUILD.bazel, line 67 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Done.

The whole filegroup

---

go/cs/schema.sql, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Done.

The whole file

[scrye]

Reviewable status: 153 of 154 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

---

go/cs/schema.sql, line 1 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

The whole file

Done.

[lukedirtwalker]

Reviewed 2 of 2 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved