Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: Add linter for log statements #3663

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Feb 11, 2020

Adds linter for log statements.
Also, fix all the places the linter flagged in the codebase.


This change is Reviewable

Adds linter for log statements.
Also, fix all the places the linter flagged in the codebase.
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: 💯

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)

a discussion (no related file):
hm I just realized that the case in the BR is not catched: https://github.com/scionproto/scion/blob/master/go/border/rctrl/ifstate.go#L45

But it's certainly better than nothing.


Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit ea92fee into scionproto:master Feb 11, 2020
@oncilla oncilla deleted the pub-log-check branch February 11, 2020 10:08
@oncilla
Copy link
Contributor Author

oncilla commented Feb 11, 2020

a discussion (no related file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

hm I just realized that the case in the BR is not catched: https://github.com/scionproto/scion/blob/master/go/border/rctrl/ifstate.go#L45

But it's certainly better than nothing.

created oncilla/gochecks#6 to track this


stygerma pushed a commit to stygerma/scion that referenced this pull request Mar 26, 2020
Adds linter for log statements.
Also, fix all the places the linter flagged in the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants