tools: fix wireshark dissector SPAO MAC offset #4289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MAC of the SHA1-AES-CBC algorithm starts at an offset of 32 bytes.
matzf
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @fstreun)
matzf
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Reviewable status:
benthor
pushed a commit
to benthor/scion
that referenced
this pull request
Nov 24, 2022
The MAC of the SHA1-AES-CBC algorithm starts at an offset of 32 bytes (not 31).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MAC for the SHA1-AES-CBC algorithm starts at an offset of 32 bytes.
This change is