Ensure GIL during C callbacks #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had segfaults when using Ecole + an event handler registered through PySCIPOpt, which this PR seems to fix. Any reason it hasn't been merged yet ? Related discussion about this issue here: |
|
@mattmilten do you have some insight here? |
|
I guess we can merge this. I don't see an issue and the tests pass ¯\_(ツ)_/¯ |
|
Awesome. It seems safe indeed. And it would greatly improve the Ecole + PySCIPOpt compatibility :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During all C callbacks ensure that the GIL is held before executing Python code.
In Ecole we don't hold the GIL when calling
SCIPsolve, so if users have added a callback through Python, user would getThis is a prerequisite to #430 , but I think it we should do a bit more testing before actually removing the GIL in intensive methods.