Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added set_obj_integral Method #101

Merged
merged 5 commits into from
Aug 12, 2023
Merged

Added set_obj_integral Method #101

merged 5 commits into from
Aug 12, 2023

Conversation

CodingTil
Copy link
Contributor

@CodingTil CodingTil commented Aug 11, 2023

See Issue #95

cargo build runs through, as well as cargo fmt (at least for my code).
I am unable to run cargo test at the moment, it currently says it cannot find libscip.8.0.dylib - seems unrelated to my code.


Changelog:

@CodingTil CodingTil marked this pull request as draft August 11, 2023 21:24
@CodingTil
Copy link
Contributor Author

Update: Managed to get cargo test working. Test fails: [scip_prob.c:1547] ERROR: method is not callable in SCIP stage <0>
I think see https://github.com/scipopt/scip/blob/beae291be2e4daf8cf581c2b703bd38c53dd5dcf/src/scip/scip_prob.c#L1509 - one cannot call it at the Unsolved Stage?

@CodingTil CodingTil marked this pull request as ready for review August 11, 2023 21:35
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #101 (093957e) into main (1ffb0d1) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   91.29%   91.36%   +0.06%     
==========================================
  Files          13       13              
  Lines         804      810       +6     
==========================================
+ Hits          734      740       +6     
  Misses         70       70              
Files Changed Coverage Δ
src/model.rs 97.86% <100.00%> (+0.03%) ⬆️
src/scip.rs 98.21% <100.00%> (+0.01%) ⬆️

Copy link
Member

@mmghannam mmghannam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the useful contribution. Just one minor change request and would be ready to merge, please don't forget to update the changelog.

src/model.rs Outdated Show resolved Hide resolved
@CodingTil
Copy link
Contributor Author

please don't forget to update the changelog

Oh, I realize now you meant CHANGELOG.md - will do that

@mmghannam mmghannam enabled auto-merge (squash) August 12, 2023 09:42
@mmghannam
Copy link
Member

Perfect, thanks again @CodingTil! Will merge right after the pipelines pass, looking forward to your next contribution :)

@mmghannam mmghannam merged commit b260e19 into scipopt:main Aug 12, 2023
4 checks passed
mmghannam pushed a commit that referenced this pull request Aug 22, 2023
* Added set_obj_integral() function

* Added test for set_obj_integral

* Moved new method to Model<ProblemCreated>

* Update method signature to always return Self

* Updated CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants