Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Create workflow to rebase this fork to the latest upstream tag #57

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EwoutH
Copy link

@EwoutH EwoutH commented Jun 21, 2022

This workflow runs daily and opens a PR is there is a new tag available upstream, to sync it to that tag.

This workflow runs daily and opens a PR is there is a new tag available upstream, to sync it to that tag.
@EwoutH
Copy link
Author

EwoutH commented Jun 21, 2022

GitHub Actions needs to be enabled on https://github.com/scipy/HiGHS/actions for it to work, could a maintainer enable it?

@rgommers
Copy link
Member

Thanks @EwoutH. Two issues I think I see with the mechanics of this:

  • this is going to open a new PR for the same tag each day until the first PR is merged, isn't it?
  • this action should not run on forks (that'd make the same mess that Dependabot makes)

@mckib2 what do you think? The notifications may be useful, assuming the issues above are taken care of.

Prevent the action from running (daily) on forks, by requiring the action to be either run on the scipy/HiGHS repo or be triggered by something else than the schedule.

This way daily jobs won't run on forks, but maintenance can still be tested there.
@EwoutH
Copy link
Author

EwoutH commented Jun 22, 2022

Thanks for reviewing!

this is going to open a new PR for the same tag each day until the first PR is merged, isn't it?

Good remark! Fortunatly the peter-evans/create-pull-request step considers this, and only opens up a PR if there isn't one open already.

this action should not run on forks (that'd make the same mess that Dependabot makes)

Excellent catch. By default CI is disabled on forks, but I addressed that in e146f29 to be safe.

@mckib2
Copy link
Collaborator

mckib2 commented Jun 26, 2022

@mckib2 what do you think? The notifications may be useful, assuming the issues above are taken care of.

Yes, I think this would be useful. Is it (or can it?) tag appropriate maintainers such as myself? If it's a burden in the future, we can always turn it off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants