Remove ecosystem stuff and port to scientific-python-hugo-theme #413

jarrodmillman · 2021-10-12T01:08:55Z

Closes #357, closes #99, closes #117, closes #382. This is a big change, but it is fairly straightforward. It does two main things.

Replaces the scipy sphinx theme with the numpy.org hugo theme. Since we plan to use the numpy.org theme for multiple sites, we created https://github.com/scientific-python/scientific-python-hugo-theme. I will create a PR to numpy/numpy.org to switch them to scientific-python-hugo-theme. @stefanv and I will maintain scientific-python-hugo-theme and will implement whatever numpy.org and scipy.org want. (numpy.org has a web team that we need to talk to about the theme stuff, but we plan to follow their lead and intend to provide any help they need/want.)
Removes the ecosystem stuff. Essentially, I replaced https://scipy.org with https://scipy.org/scipylib and removed scipy.org/scipylib. Since I moved to a new theme this involved moving the files and changing them from rst to md files. I used pandoc and manually reviewed the results. This change broke the tables. To make things easier to edit, we implemented a table syntax that you can see in, for example, content/en/download.md.

@stefanv and I are more than happy to help maintain this site for the next few years as part of our work on the https://scientific-python.org project. I suspect it would be worth updating the text on the site. But I think it makes more sense to merge this and then to make additional changes. I would be happy to help coordinate this, implement things that the group wants, and review other PRs.

ilayn · 2021-10-12T01:37:47Z

We can go over the details but thanks for this folks!

tupui · 2021-10-12T10:06:43Z

Wooo thanks, this looks great! Not sure how we should go about this. Maybe we should already strip it down to the bare minimum (removing FAQ, gallery etc. which are currently for NumPy or SciPy ecosystem). Then we can decide in other PRs about what to add.

If we want to keep this already, then I can take some time to help go over all files.

jarrodmillman · 2021-10-12T18:18:55Z

I force-pushed the newsite branch from 13aa0c3 to 444a401. The only change I made was to use the official logo. Originally, I found the logo via a web search on some random site. @rgommers provided a link to the official logo (see https://github.com/scientific-python/scipy.org-new/issues/12).

Here is what I had before

Now it looks like:

Here are the favicons with a dark and light theme:

The official logo has a transparent snake now (before it was white). I don't have a strong opinion, but I think the transparent snake makes the favicon hard to see with the dark theme. That is fine with me, I just wanted to point it out.

tupui · 2021-10-12T18:32:38Z

Personally I prefer the white snake. It's more readable. The favicon would also look better. Maybe we can add some white in the official logo?

stefanv · 2021-10-12T18:33:42Z

The official logo has a transparent snake now (before it was white). I don't have a strong opinion, but I think the transparent snake makes the favicon hard to see with the dark theme. That is fine with me, I just wanted to point it out.

I'd fill that snake with white, at least for the favicon. Maybe we should consider for the footer logo as well.

tupui · 2021-10-12T18:34:27Z

I'd fill that snake with white, at least for the favicon. Maybe we should consider for the footer logo as well.

Yes also the GitHub icon could be white IMO. But we could see all these later. This is already so much better than what we actually have 😅

rgommers · 2021-10-12T18:51:07Z

I think it's just a problem with the official logo SVG file. It should always be white. We should redesign the logo at some point anyway, or at least have a graphic designer clean it up. For now let's just do what looks best.

jarrodmillman · 2021-10-12T21:10:28Z

@stefanv did some minor clean up of the logo: scipy/archive#2

I will update the logo here after that has been reviewed.

tupui

I went through all the files, not much to adjust 👍

config.yaml

tupui · 2021-10-13T10:06:38Z

Makefile

+	hugo $(BASEURLARG)
+	touch public/.nojekyll
+
+public/.nojekyll: html


Is this a leftover, or you plan on adding something else?

@rgommers, @ilayn, @tupui I updated the Makefile in 09f2da9. I am not certain that it is correct, so it would be good if you could carefully review it. Also, I have some questions:

Deployments

Do we still want to deploy to the Enthought servers? Or should we use netlify or gh-pages?

Redirects

Do we still want to do all the redirects from the old Moin site?

Since this moves everything up a level, do we want to add redirects from scipy.org/scipylib/* to scipy.org/* now?

I'd say yes to redirects from scipylib/* and let's get rid of the Moin redirects - those are a decade old by now and shouldn't get many hits anymore.

Do we still want to deploy to the Enthought servers? Or should we use netlify or gh-pages?

Let's do it properly and deploy to netlify/cloudflare/gh-pages. I think GitHub Pages is the most practical for deployment, and Netlify for preview.

Of those, I think only Netlify supports easy redirects.

Ah yes, forgot about that. We should probably go with the non-free version then, so we can give anyone who wants to help maintain it access.

config.yaml

content/en/bug-report.md

content/en/mailing-lists.md

content/en/install.md

static/gallery/team.html

static/images/README.md

Co-authored-by: Pamphile ROY <roy.pamphile@gmail.com>

tupui · 2021-10-15T15:26:36Z

If this is going in soon, as pointed in scipy/scipy#14267, maybe we should redirect to the dev doc for now.

rgommers · 2021-10-15T15:28:55Z

I'd be inclined to merge it soon, and then we can iterate on it more quickly. Can you send a message to the mailing list about it @jarrodmillman? I don't expect much there beside a bunch of thank you's, but it's a change we should run by the list.

netlify · 2021-10-15T23:30:52Z

✔️ Deploy Preview for loving-hopper-c72a13 ready!

🔨 Explore the source changes: 56201aa

🔍 Inspect the deploy log: https://app.netlify.com/sites/loving-hopper-c72a13/deploys/617105781806ce0007a5d3a1

😎 Browse the preview: https://deploy-preview-413--loving-hopper-c72a13.netlify.app/donations

jarrodmillman · 2021-10-18T14:58:55Z

There are two minor things I want to take care of before this is ready to merge. I will update this PR by the end of the day.

rgommers · 2021-10-20T12:18:59Z

We should keep a link to the SciPy conference website - perhaps in the footer?

jarrodmillman · 2021-10-20T21:51:09Z

@rgommers @tupui @ilayn I believe this is "ready" to merge. I created issue #418 to track what we need to do to deploy the new site after this is merged. @stefanv and I will take care of the DNS stuff. We will set up draft.scipy.org once you merge this PR. And we will wait to update scipy.org until a decision is made on #418.

ilayn

I'll just give others to have a one final look and then we can click the button, once again thanks a lot for the effort folks!

tupui

LGTM as well, thanks a ton!

rgommers

Went through all the pages, content seems fine, all links seem to work, and it looks great. In it goes!

See scipy/scipy.org#413 (comment).

jarrodmillman requested a review from rgommers October 12, 2021 01:08

jarrodmillman mentioned this pull request Oct 12, 2021

factoring out the theme numpy/numpy.org#475

Closed

Remove ecosystem stuff and port to scientific-python-hugo-theme

444a401

jarrodmillman force-pushed the newsite branch from 13aa0c3 to 444a401 Compare October 12, 2021 18:11

tupui reviewed Oct 13, 2021

View reviewed changes

jarrodmillman and others added 3 commits October 13, 2021 13:05

Apply suggestions from code review

9955c26

Co-authored-by: Pamphile ROY <roy.pamphile@gmail.com>

Update content/en/faq.md

1deb1f7

Co-authored-by: Pamphile ROY <roy.pamphile@gmail.com>

Remove cruft

32433c9

jarrodmillman mentioned this pull request Oct 13, 2021

Team galleries #414

Closed

Remove NumPy stuff

da2ab03

jarrodmillman force-pushed the newsite branch from a00bf11 to da2ab03 Compare October 13, 2021 21:15

Update makefile

09f2da9

jarrodmillman mentioned this pull request Oct 14, 2021

Installation #415

Closed

Update logo from archive

c5c1c0a

jarrodmillman force-pushed the newsite branch 2 times, most recently from a451733 to de29232 Compare October 15, 2021 23:30

Add netlify config

161d9d8

jarrodmillman force-pushed the newsite branch from de29232 to 161d9d8 Compare October 15, 2021 23:36

Use dev docs for now

0b6759e

jarrodmillman added 2 commits October 20, 2021 14:08

Update theme

269cee3

Link to conference

50139b0

jarrodmillman mentioned this pull request Oct 20, 2021

Deploy new site #418

Closed

14 tasks

jarrodmillman added 2 commits October 20, 2021 14:52

Remove circle ci conf (using netlify)

4a7244b

Use https for submodule

8ca70d3

ilayn approved these changes Oct 20, 2021

View reviewed changes

tupui approved these changes Oct 21, 2021

View reviewed changes

Fix donation button and text

56201aa

stefanv force-pushed the newsite branch from 0ee11ec to 56201aa Compare October 21, 2021 06:15

stefanv approved these changes Oct 21, 2021

View reviewed changes

rgommers approved these changes Oct 21, 2021

View reviewed changes

rgommers merged commit 0f45433 into scipy:master Oct 21, 2021

astrojuanlu added a commit to astrojuanlu/packaging.python.org that referenced this pull request Nov 22, 2021

SciPy promotes Homebrew now

7f7f4c2

See scipy/scipy.org#413 (comment).

jarrodmillman mentioned this pull request Aug 8, 2022

Add old topical software page scientific-python/scientific-python.org#286

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove ecosystem stuff and port to scientific-python-hugo-theme #413

Remove ecosystem stuff and port to scientific-python-hugo-theme #413

jarrodmillman commented Oct 12, 2021 •

edited

Loading

ilayn commented Oct 12, 2021

tupui commented Oct 12, 2021

jarrodmillman commented Oct 12, 2021

tupui commented Oct 12, 2021 •

edited

Loading

stefanv commented Oct 12, 2021

tupui commented Oct 12, 2021 •

edited

Loading

rgommers commented Oct 12, 2021

jarrodmillman commented Oct 12, 2021

tupui left a comment

tupui Oct 13, 2021

jarrodmillman Oct 13, 2021 •

edited

Loading

rgommers Oct 13, 2021

stefanv Oct 13, 2021

rgommers Oct 14, 2021

tupui commented Oct 15, 2021 •

edited

Loading

rgommers commented Oct 15, 2021

netlify bot commented Oct 15, 2021 •

edited

Loading

jarrodmillman commented Oct 18, 2021

rgommers commented Oct 20, 2021

jarrodmillman commented Oct 20, 2021

ilayn left a comment

tupui left a comment

rgommers left a comment

Remove ecosystem stuff and port to scientific-python-hugo-theme #413

Remove ecosystem stuff and port to scientific-python-hugo-theme #413

Conversation

jarrodmillman commented Oct 12, 2021 • edited Loading

ilayn commented Oct 12, 2021

tupui commented Oct 12, 2021

jarrodmillman commented Oct 12, 2021

tupui commented Oct 12, 2021 • edited Loading

stefanv commented Oct 12, 2021

tupui commented Oct 12, 2021 • edited Loading

rgommers commented Oct 12, 2021

jarrodmillman commented Oct 12, 2021

tupui left a comment

Choose a reason for hiding this comment

tupui Oct 13, 2021

Choose a reason for hiding this comment

jarrodmillman Oct 13, 2021 • edited Loading

Choose a reason for hiding this comment

Deployments

Redirects

rgommers Oct 13, 2021

Choose a reason for hiding this comment

stefanv Oct 13, 2021

Choose a reason for hiding this comment

rgommers Oct 14, 2021

Choose a reason for hiding this comment

tupui commented Oct 15, 2021 • edited Loading

rgommers commented Oct 15, 2021

netlify bot commented Oct 15, 2021 • edited Loading

jarrodmillman commented Oct 18, 2021

rgommers commented Oct 20, 2021

jarrodmillman commented Oct 20, 2021

ilayn left a comment

Choose a reason for hiding this comment

tupui left a comment

Choose a reason for hiding this comment

rgommers left a comment

Choose a reason for hiding this comment

jarrodmillman commented Oct 12, 2021 •

edited

Loading

tupui commented Oct 12, 2021 •

edited

Loading

tupui commented Oct 12, 2021 •

edited

Loading

jarrodmillman Oct 13, 2021 •

edited

Loading

tupui commented Oct 15, 2021 •

edited

Loading

netlify bot commented Oct 15, 2021 •

edited

Loading