-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: remove support for Python 3.7 (hence NumPy 1.16) #14655
Conversation
8c2fbfe
to
656ca44
Compare
Note: In the process, I tried to update to ubuntu:20.04 instead of 18.04 in a few workflows, but it causes a warning
and also a different value in a doctest File "build/testenv/lib/python3.8/site-packages/scipy/optimize/optimize.py", line 994, in check_grad
Failed example:
check_grad(func, grad, [1.5, -1.5])
Expected:
2.9802322387695312e-08
Got:
4.2146848510894035e-08 So I reverted these and now all is passing. |
I always get the |
Interesting, maybe something to look at after that. Or if you know a simple fix we can also do this now. I could not reproduce locally. |
I haven't thought about a fix. Previously I had assumed it must be a very specific thing, but it sounds it's at least a little more widespread. Note that this is my Windows machine, not Ubuntu. |
Platform-specific failures are always good to fix; if you see them locally while CI is green, it usually means others see them too. |
Ok, then I can re-update the CI to use 20.04 to make the CI fail. It will just not work for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. We should add 3.10, but that's best done in a separate PR.
This is green now, so I'd leave that for a separate follow-up PR.
We should bump the lowest GCC version, but last time we tried there was an issue on the scipy-wheels repo, so best not to do it in this PR. |
Also once this is merged, scipy-wheels should be updated to match. Do you want to do that @tupui? |
Ok great then! I will look at bumping GCC as soon as this merges. For the other bug, @mdhaber do you have time to take a look since you can reproduce? |
It's all green, so let's give it a go - merged. |
Sure, glad to learn how and help with that. |
We should be dropping Python 3.7 with the next release (1.8), hence NumPy 1.16 will not be supported and we will move to NumPy 1.17.3.
This PR touches the
setup.py
,pyproject.toml
, CI, some other smaller things and some documentation.Related to recent discussions and linked to #14649. Also in accordance with NEP29 (NumPy already dropped support for 3.7 on main). And see here for official Python support. There will be just 1 year of support of 3.7 for the next release if we don't migrate now.
I think I touched everything with these 2 PRs. Just not sure about the Dockerfile.