Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the test tolerance for examining how different minimiser methods cope with equal bounds.
The test examines the output from a finite differences minimisation vs one that uses a (callable) analytic gradient. In the former factorisation is carried out, in the latter it isn't; this is probably enough to generate differences in the output. Indeed, the arm64 nightly wheels on MacPython were failing because of the specified tolerances:
I therefore relaxed the tolerances to allow the test to pass. This is quite a big bump, from 3e-6 to 5e-4, a couple of orders of magnitude. This might indicate that improvements are needed for TNC.
I therefore decided to add an extra test that would compare the output of two minimisation run that both use finite differences. The first test has two parameters with equal bounds, with two varying parameters (for a total of 4 params). The output of this is then compared to a minimisation that only has the two varying parameters from the first. I would expect the two runs to be pretty much identical.