Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes sftp inputstream reads #1793

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fixes sftp inputstream reads #1793

merged 1 commit into from
Jul 20, 2023

Conversation

mkeckmkeck
Copy link
Contributor

@mkeckmkeck
Fixes sftp inputstream reads
2b26233 
- org.apache.sshd.sftp.client.impl.SftpInputStreamAsync#read(byte[], int, int) sometimes
  behaves incorrectly when reading a length of 0 by returning -1 whilst the actual buffer does
  not hit EOF yet
- see apache/mina-sshd#398 for details
- the BufferedInputStream is a workaround, as it early returns 0 when requesting length 0
@mkeckmkeck mkeckmkeck merged commit 31ffc41 into develop Jul 20, 2023
mkeckmkeck added a commit that referenced this pull request Jul 20, 2023
@mkeckmkeck
Merge pull request #1793 from scireum/mke/fix_sftp_inputstream
5a4acb4 
Fixes sftp inputstream reads
@jakobvogel jakobvogel deleted the mke/fix_sftp_inputstream branch July 25, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyHa andyHa andyHa approved these changes

@sabieber sabieber sabieber approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@idlira idlira idlira approved these changes

@ymo-sci ymo-sci ymo-sci approved these changes

@mko-sci mko-sci mko-sci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mkeckmkeck @andyHa @sabieber @fhaScireum @idlira @ymo-sci @mko-sci