Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements input validation for SAML fingerprints for tenants #1940

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Implements input validation for SAML fingerprints for tenants #1940

merged 3 commits into from
Feb 22, 2024

Conversation

scireum-mbo
Copy link
Contributor

Description

Before:
image

After:
image

Additional Notes

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@scireum-mbo scireum-mbo added 🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review labels Feb 21, 2024
@sabieber sabieber merged commit ac4e04d into develop Feb 22, 2024
2 checks passed
@sabieber sabieber deleted the feature/mbo/OX-10835 branch February 22, 2024 10:48
ymo-sci
ymo-sci approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@ymo-sci ymo-sci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use html input pattern instead of js?

@scireum-mbo scireum-mbo mentioned this pull request Feb 28, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@ymo-sci ymo-sci ymo-sci approved these changes

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scireum-mbo @sabieber @ymo-sci @mkeckmkeck