SIRI-942 revamp saving of code-list-entries #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to changes of Bootstrap5 we set the code to disabled to have correct css. disabled field won't be sent in the request, so we change the route and include the id in the route. This also unifies the behaviour to many other routes, where /entity/new is the route to create a new entity and /entity/:1 will show the editor as well for entry with given id. BREAKING - Changed behaviour: - if you create a new code-list-entry with an existing code we now no more edit the existing one (which was also kindly unintuitive until now) and will throw an error instead.. - fixes: SIRI-942
ymo-sci
added
🐛 Bugfix
sabieber
approved these changes
Mar 7, 2024
fhaScireum
approved these changes
Mar 8, 2024
idlira
approved these changes
Mar 11, 2024
jakobvogel
approved these changes
Mar 11, 2024
mkeckmkeck
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to changes of Bootstrap5 we set the code to disabled to have correct css. disabled field won't be sent in the request, so we change the route and include the id in the route. This also unifies the behaviour to many other routes, where /entity/new is the route to create a new entity and /entity/:1 will show the editor as well for entry with given id.
BREAKING - Changed behaviour: - if you create a new code-list-entry with an existing code we now no more edit the existing one (which was also kindly unintuitive until now) and will throw an error instead..
Occurrences of route-calling of
/code-list/:1/entrymust be changed to/code-list/:1/entry/:2Additional Notes
Checklist