Fixes button for multiple selections to behave correctly #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: OX-10886
sabieber
approved these changes
Mar 11, 2024
| if (!autocomplete.val().includes(code)) { | ||
| autocomplete.addToken({value: code, text: name}); | ||
| } else { | ||
| autocomplete.select.removeTokenWithText(name); |
There was a problem hiding this comment.
Optional: I think the library may benefit from a removeTokenWithValue helper as this would be more robust than relying on unique display texts for each option (which most likely should be the case most of the time)
jakobvogel
approved these changes
Mar 11, 2024
idlira
approved these changes
Mar 12, 2024
mkeckmkeck
approved these changes
Mar 12, 2024
ymo-sci
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Notes
Checklist