Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relaxes race condition with autosetup a little #1952

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Relaxes race condition with autosetup a little #1952

merged 1 commit into from
Mar 13, 2024

Conversation

mkeckmkeck
Copy link
Contributor

@mkeckmkeck mkeckmkeck commented Mar 13, 2024 •
edited
Loading

Description

  • when running on an empty db, autosetup might create a system tenant
  • we require the tenant's name at process creation, so wait a little longer before evaluating the supplier
  • this might be relevant in test scenarios where empty databases are used frequently

Additional Notes

  • This PR fixes or works on following ticket(s): SIRI-939
  • This PR is related to PR:

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@mkeckmkeck
Relaxes race condition with autosetup a little
2935b92 
- when running on an empty db, autosetup might create a system tenant
- we require the tenant's name at process creation, so wait a little longer before
  evaluating the supplier
- this might be relevant in test scenarios where empty databases are used frequently

Fixes: SIRI-939
@mkeckmkeck mkeckmkeck added the 🐛 Bugfix Contains only a small fix for an existing bug label Mar 13, 2024
@mkeckmkeck mkeckmkeck merged commit 9017f59 into develop Mar 13, 2024
4 checks passed
@mkeckmkeck mkeckmkeck deleted the mke/SIRI-939_process_racecondition branch March 13, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@ymo-sci ymo-sci ymo-sci approved these changes

Assignees
No one assigned
Labels
🐛 Bugfix Contains only a small fix for an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkeckmkeck @sabieber @jakobvogel @ymo-sci