Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArchiveImportJob: Improvements #1953

Merged
merged 2 commits into from
Mar 14, 2024
Merged

ArchiveImportJob: Improvements #1953

merged 2 commits into from
Mar 14, 2024

Conversation

jakobvogel
Copy link
Member

@jakobvogel jakobvogel commented Mar 13, 2024 •
edited
Loading

Description

  • Streaming: The new method wraps an already existing interface accepting a pointer to a consumer. The stream object allows for more readable filtering and processing.
  • Error Handling: Refactoring the creation of exceptions into a helper method allows use in Optional.orElseThrow(…), leading to shorter and more elegant code.

Additional Notes

  • This PR fixes or works on following ticket(s): OX-10756

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices

@jakobvogel
Provides method to stream all entries of the archive 🎏
032cf24 
The new method just wraps an already existing interface accepting the pointer to a consumer. The stream object allows for more readable filtering and processing.

OX-10756
@jakobvogel jakobvogel added the 🧬 Enhancement Contains new features label Mar 13, 2024
@jakobvogel
Refactors code into auxiliary method 📦
7f8fffc 
The new method enables streamlining of code using optionals, such as the ones returned by `fetchEntry(…)`

OX-10756
@jakobvogel jakobvogel changed the title Streaming for Archive Import Jobs ArchiveImportJob: Improvements Mar 13, 2024
@jakobvogel jakobvogel merged commit 53ccb76 into develop Mar 14, 2024
3 checks passed
@jakobvogel jakobvogel deleted the feature/jvo/OX-10756-Streamy-McStreamStream branch March 14, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@idlira idlira idlira approved these changes

@mko-sci mko-sci mko-sci approved these changes

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakobvogel @sabieber @fhaScireum @idlira @mko-sci