SAML: Redirect Fix #1958
Merged
SAML: Redirect Fix #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to route back to the originally intended site after a SAML login, the login site stores the original URL in the local storage. This is done by passing the URL to the Pasta template and rendering the string as part of a respective JavaScript snippet. If a URL contains characters with significance in HTML such as `&`, though, the Pasta string renderer converts these to HTML entities unless everything is placed within `<i:raw>`. SIRI-937
jakobvogel
added
🐛 Bugfix
sabieber
approved these changes
Mar 21, 2024
ymo-sci
approved these changes
Mar 22, 2024
mkeckmkeck
approved these changes
Mar 22, 2024
idlira
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to route back to the originally intended site after a SAML login, the login site stores the original URL in the local storage. This is done by passing the URL to the Pasta template and rendering the string as part of a respective JavaScript snippet. If a URL contains characters with significance in HTML such as
&, though, the Pasta string renderer converts these to HTML entities unless everything is placed within<i:raw>.Additional Notes
Checklist