-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses CustomEvents within ImportJobs #1961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is only one script present, it will be ued right away. Only if there are several present for the current tenant, the user can pick which should be used. This way, a script will be automatically used everywhere if only one exists. If the script is optional, a second and empty script can be provided.
idlira
approved these changes
Apr 2, 2024
sabieber
approved these changes
Apr 2, 2024
idlira
reviewed
Apr 3, 2024
sabieber
approved these changes
Apr 3, 2024
The other load gets triggered way to often (for each find etc.)
Although currently only available to the system tenant, we plan on making the scripting API safe in terms of sandboxing so that normal users could provide scripts as well.
Also adds a word of caution for others to maintain the sort order.
We probably only want one event instead of one event per job type, as the internal types are not that easy to guess.
This is mainly used for debugging purposes
fhaScireum
approved these changes
Apr 3, 2024
sabieber
approved these changes
Apr 3, 2024
idlira
approved these changes
Apr 3, 2024
mkeckmkeck
approved these changes
Apr 3, 2024
sabieber
approved these changes
Apr 3, 2024
mkeckmkeck
approved these changes
Apr 3, 2024
andyHa
added
the
🕔 Wait for sirius
Needs new version from another sirius lib to work
label
Apr 3, 2024
mkeckmkeck
approved these changes
Apr 4, 2024
sabieber
approved these changes
Apr 4, 2024
idlira
approved these changes
Apr 4, 2024
sabieber
approved these changes
Apr 4, 2024
idlira
removed
the
🕔 Wait for sirius
Needs new version from another sirius lib to work
label
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes import jobs dispatch custom events.
Example Scripts:
Relates to:
Checklist