Tenant Scripting Enhancements #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: OX-9839
Fixes: OX-9839
Fixes: OX-9839
ensuring its loading the latest state of scripts Fixes: OX-9839
enableScriptableEvents must be overwritten so scripting takes effect. If active, and only one script exists, the parameter is collected hidden and the first entry will be the default one. This also provides better tracking to which dispatcher was actually used (even a hidden one) since the parameter and its value is logged at job start. Fixes: OX-9839
idlira
added
🧬 Enhancement
sabieber
approved these changes
Apr 5, 2024
src/main/resources/default/templates/biz/scripting/mongo-scripts.html.pasta
Outdated
Show resolved
Hide resolved
jakobvogel
approved these changes
Apr 5, 2024
src/main/java/sirius/biz/scripting/mongo/MongoCustomScriptController.java
Outdated
Show resolved
Hide resolved
src/main/java/sirius/biz/scripting/mongo/MongoCustomScriptController.java
Outdated
Show resolved
Hide resolved
Fixes: OX-9839
Co-authored-by: Jakob Vogel <jvo@scireum.de>
sabieber
approved these changes
Apr 5, 2024
Should not. In fact the new field is not even in the index, I will add it... |
and changes queries to use $eq instead of $ne. Since the entity is new, there is no need to resave them unless in a few local systems Fixes: OX-9839
sabieber
approved these changes
Apr 5, 2024
Fixes: OX-9839
sabieber
approved these changes
Apr 5, 2024
Fixes: OX-9839
andyHa
reviewed
Apr 5, 2024
fhaScireum
approved these changes
Apr 5, 2024
Fixes: OX-9839
sabieber
approved these changes
Apr 5, 2024
andyHa
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ImportBatchProcessFactory.enableScriptableEventsmethod. For this to work, we changed the magic detection logic when only one script exists: with the feature disabled, no parameter is collected, thus the NOOP_DISPATCHER is used. If the parameter is collected but contains only one single entry, its hidden by default. One of the main advantages is, that even for hidden parameters the job will log the default script used during its initialization, eg:Additional Notes
Checklist