Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements entityId to t:tracing for copying entity ids more easily #1967

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Implements entityId to t:tracing for copying entity ids more easily #1967

merged 4 commits into from
Apr 8, 2024

Conversation

scireum-mbo
Copy link
Contributor

@scireum-mbo scireum-mbo commented Apr 8, 2024 •
edited
Loading

Description

Before:
image

After:
image

With filled body:
image

Additional Notes

  • This PR fixes or works on following ticket(s): SIRI-950

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@scireum-mbo
Adds new entityId argument to template
c6b168f 
Fixes: SIRI-950
@scireum-mbo
Implements new argument in read-only textfield for copying the entity id
8466afe 
Has an "i:if", because it is an optional parameter and we don't need to render the field if the parameter isn't set.

Fixes: SIRI-950
@scireum-mbo
Adds key for the entity id
ccebd54 
Fixes: SIRI-950
@scireum-mbo scireum-mbo added the 🧬 Enhancement Contains new features label Apr 8, 2024
@mko-sci
Copy link
Contributor

mko-sci commented Apr 8, 2024

Also UI-technisch finde ich das noch nicht so gut.
Sieht nicht gut aus.

Evtl. die ID mit in die Überschriftszeile, oder direkt darunter in einer Zeile komplett?

jakobvogel
jakobvogel approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@jakobvogel jakobvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technisch okay, über die Platzierung des Feldes kann man IMHO reden. (Und Tracing ist gerade auf Unterseiten auch nicht unbedingt immer eingebunden)

@sabieber
Copy link
Member

sabieber commented Apr 8, 2024

Regarding Placement: Maybe also test the case where additional information is included via the body-block of the tag. If I remember correctly this is possible and should also work well with the new field.

@scireum-mbo scireum-mbo merged commit 4089f84 into develop Apr 8, 2024
3 checks passed
@scireum-mbo scireum-mbo deleted the feature/mbo/SIRI-950 branch April 8, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@idlira idlira idlira approved these changes

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

@mko-sci mko-sci mko-sci approved these changes

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@scireum-mbo @mko-sci @sabieber @jakobvogel @idlira @mkeckmkeck