Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark blob lowercased fields with sirius db annotation #1968

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Mark blob lowercased fields with sirius db annotation #1968

merged 2 commits into from
Apr 9, 2024

Conversation

mkeckmkeck
Copy link
Contributor

@mkeckmkeck mkeckmkeck commented Apr 9, 2024 •
edited
Loading

Description

Mark blob lowercased fields with sirius db annotation. The actual lowercasing cannot be removed, as it gets called within some additional logic and from other places

Additional Notes

  • This PR fixes or works on following ticket(s): SIRI-951

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@mkeckmkeck
Mark blob lowercased field with sirius db annotation
42d4832 
- the actual lowercasing cannot be removed, as it gets called within
  some additional logic and from other places

Fixes: SIRI-951
@sabieber sabieber added the 🕔 Wait for sirius Needs new version from another sirius lib to work label Apr 9, 2024
@mkeckmkeck mkeckmkeck added the 🧬 Enhancement Contains new features label Apr 9, 2024
@mkeckmkeck mkeckmkeck removed the 🕔 Wait for sirius Needs new version from another sirius lib to work label Apr 9, 2024
@mkeckmkeck mkeckmkeck merged commit 7388840 into develop Apr 9, 2024
3 of 4 checks passed
@mkeckmkeck mkeckmkeck deleted the mke/SIRI-951_blob_normalize branch April 9, 2024 13:56
@mkeckmkeck mkeckmkeck mentioned this pull request Apr 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@idlira idlira idlira approved these changes

@mko-sci mko-sci mko-sci approved these changes

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkeckmkeck @sabieber @jakobvogel @idlira @mko-sci