Maintenance: Unused Method (OX-10783) #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as the PDF generator now supports direct use of plain URLs. We no longer need to manually output special URLs. OX-10783
jakobvogel
added
🧬 Enhancement
mkeckmkeck
approved these changes
Sep 17, 2024
scireum-mbo
approved these changes
Sep 17, 2024
mko-sci
approved these changes
Sep 17, 2024
sabieber
approved these changes
Sep 17, 2024
jakobvogel
added
🖐 Keep open
ymo-sci
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes a method that has been introduced while working on OXOMI's new PDF datasheet renderer. In the meantime, the PDF generator now supports direct use of plain URLs. We no longer need to manually output special URLs, and the deleted method is now unused. S2 apparently never used the method at all. The PR is thus only mildly breaking. 😇
Additional Notes
Checklist