Allow 1 and 0 for boolean values in Value#asBoolean #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in https://www.w3.org/TR/2004/REC-xmlschema-2-20041028/#boolean 1 and 0 are also allowed as valid boolean values. In Some places we read from XML and have StructuredNode.queryValue("VALUE_WITH_0_OR_1").asBoolean(false) which should also return true if the value is 1 - fixes: SE-13483
ymo-sci
added
🐛 Bugfix
Therefore add missing tests for coerce with default values and always trim to be less strict BREAKING: Value#coerce(Boolean.class, true) now return true as expected and no longer false if the value is empty - fixes: SE-13483
jakobvogel
approved these changes
Mar 21, 2024
idlira
requested changes
Mar 21, 2024
- fixes: SE-13483
mkeckmkeck
approved these changes
Mar 21, 2024
sabieber
approved these changes
Mar 21, 2024
fix typo Co-authored-by: Sascha Bieberstein <sabieber@users.noreply.github.com>
mko-sci
approved these changes
Mar 21, 2024
idlira
approved these changes
Mar 21, 2024
fhaScireum
approved these changes
Mar 21, 2024
andyHa
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in https://www.w3.org/TR/2004/REC-xmlschema-2-20041028/#boolean 1 and 0 are also allowed as valid boolean values. In Some places we read from XML and have StructuredNode.queryValue("VALUE_WITH_0_OR_1").asBoolean(false) which should also return true if the value is 1
BREAKING: Value#coerce(Boolean.class, true) now return true as expected and no longer false if the value is empty