SIRI-1037 Fix potential XXE vulnerability #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymo-sci
changed the title
3 tasks
sabieber
requested changes
Dec 9, 2024
mko-sci
reviewed
Dec 9, 2024
mko-sci
approved these changes
Dec 9, 2024
scireum-mbo
approved these changes
Dec 9, 2024
jakobvogel
approved these changes
Dec 9, 2024
mkeckmkeck
approved these changes
Dec 10, 2024
sabieber
approved these changes
Dec 10, 2024
idlira
approved these changes
Dec 10, 2024
fhaScireum
approved these changes
Dec 10, 2024
jmuscireum
approved these changes
Dec 10, 2024
without disallowing external entities one is able to include webcontent or files directly from the system e.g. file:///etc/hosts or some like this into the uploaded content via declaring an external entity. Details can be found on https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html#java and on https://docs.oracle.com/javase/8/docs/technotes/guides/security/jaxp/jaxp.html#feature-for-secure-processing - fixes: SIRI-1037
…ng via disallow declaration of doctypes and also disallowinf xincludes as recommended in https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html#jaxb-unmarshaller - fixes: SIRI-1037
ymo-sci
force-pushed
the
feature/ymo/SIRI-1037-xxe
branch
from
53b8d66 to
4116001
Compare
sabieber
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a potential XXE vulnerability via setting Feature Secure Processing
https://docs.oracle.com/javase/8/docs/technotes/guides/security/jaxp/jaxp.html#feature-for-secure-processing
Nicer and more current documentation:
https://docs.oracle.com/en/java/javase/23/security/java-api-xml-processing-jaxp-security-guide.html
In a nutshell, this prevents access to external entities and set limit while processing xml. As this feature is rarely required and the limits are reasonable high, we expect no problems. But testing the xml processing in products is recommended, after this change got included.
Additional Notes
Checklist