Fixes based on review comments.

scireum · Sep 11, 2018 · a0b5439 · a0b5439
1 parent 336953d
commit a0b5439
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 8 deletions.
diff --git a/src/main/java/sirius/tagliatelle/Tagliatelle.java b/src/main/java/sirius/tagliatelle/Tagliatelle.java
@@ -14,7 +14,6 @@
 import sirius.kernel.cache.Cache;
 import sirius.kernel.cache.CacheEntry;
 import sirius.kernel.cache.CacheManager;
-import sirius.kernel.commons.Explain;
 import sirius.kernel.commons.MultiMap;
 import sirius.kernel.commons.Strings;
 import sirius.kernel.commons.Tuple;
@@ -347,8 +346,6 @@ private Template resolveFromCache(String path, Resource resource) {
         return null;
     }
 
-    @SuppressWarnings("squid:S2440")
-    @Explain("False positive")
     private Template compileTemplate(String path, Resource resource, @Nullable CompilationContext parentContext)
             throws CompileException {
         CompilationContext compilationContext = createCompilationContext(path, resource, parentContext);

diff --git a/src/main/java/sirius/tagliatelle/expression/RenderEmitterExpression.java b/src/main/java/sirius/tagliatelle/expression/RenderEmitterExpression.java
@@ -23,7 +23,7 @@ public class RenderEmitterExpression implements Expression {
     private InlineTemplateEmitter emitter;
 
     /**
-     * Creates an expression with evaluates to the result of the given emitter.
+     * Creates an expression which evaluates to the result of the given emitter.
      *
      * @param emitter the emitter to wrap
      */

diff --git a/src/main/java/sirius/web/http/WebServer.java b/src/main/java/sirius/web/http/WebServer.java
@@ -783,7 +783,6 @@ protected static void removeOpenConnection(WebServerHandler webServerHandler) {
      *
      * @return a list of all currently open connections
      */
-    @SuppressWarnings("unchecked")
     public static Collection<ActiveHTTPConnection> getOpenConnections() {
         return openConnections.values();
     }

diff --git a/src/main/java/sirius/web/templates/TagliatelleContentHandler.java b/src/main/java/sirius/web/templates/TagliatelleContentHandler.java
@@ -8,7 +8,6 @@
 
 package sirius.web.templates;
 
-import sirius.kernel.commons.Explain;
 import sirius.kernel.commons.Strings;
 import sirius.kernel.di.std.Part;
 import sirius.kernel.di.std.Register;
@@ -37,8 +36,6 @@ public class TagliatelleContentHandler implements ContentHandler {
     @Part
     private Tagliatelle tagliatelle;
 
-    @SuppressWarnings("squid:S2440")
-    @Explain("False positive")
     protected Template getTemplate(Generator generator) throws CompileException {
         if (Strings.isFilled(generator.getTemplateCode())) {
             Compiler compiler = new Compiler(tagliatelle.createCompilationContext("inline", null, null),