Continuity: Allows to override the path that is used to generate deep-links #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use-cases of this could be described as edge cases but it is quite necessary for how the OXOMI frontend used the history to store its state and navigation. This new method can be used to override the path that is included in the generated history state URL externally. For example when sub-navigation occurs that should be reflected in the path. Fixes: OX-8795
andyHa
approved these changes
Jul 22, 2022
jakobvogel
approved these changes
Jul 22, 2022
cschierle
approved these changes
Jul 25, 2022
jmuscireum
approved these changes
Jul 25, 2022
ymo-sci
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use-cases of this could be described as edge cases but it is quite necessary for how the OXOMI frontend used the history to store its state and navigation.
This new method can be used to override the path that is included in the generated history state URL externally. For example when sub-navigation occurs that should be reflected in the path.
Fixes: OX-8795