Overlay: Allows to detect an overlay actively being closed by the user #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We trigger the `sci-overlay-destroyed` in the following scenarios: - Overlay closed via x button - Overlay closed via background click - Overlay closed via ESC key - Overlay closed as new one was opened The last one of these is the only one that is not triggered by the user actively trying to close the overlay but can also occur when the currently open overlay triggers a new overlay that replaces the old one. To differentiate these we now trigger a new event `sci-overlay-dismissed` in those 3 cases where the user tries to close the overlay. Fixes: OX-8917
qw3ry
approved these changes
Aug 3, 2022
meg1502
approved these changes
Aug 3, 2022
mko-sci
approved these changes
Aug 3, 2022
mkeckmkeck
approved these changes
Aug 3, 2022
cschierle
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We trigger the
sci-overlay-destroyedin the following scenarios:The last one of these is the only one that is not triggered by the user actively trying to close the overlay but can also occur when the currently open overlay triggers a new overlay that replaces the old one.
To differentiate these we now trigger a new event
sci-overlay-dismissedin those 3 cases where the user tries to close the overlay.Fixes: OX-8917