Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuity: Properly handles parsing failures of the initial state url parameter #1108

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

sabieber
Copy link
Member

Previously this crashed hard. We now recover from the failure by ignoring the invalid parameter value. We additionally call a error handler callback function when defined so custom error handling logic can be executed.

Example for Error Handler:

initialStateParseErrorHandler: function () {
    oxomi.withConfig(function () {
        oxomi.showMessageInDialog(
            oxomi.translate('history.deeplinkParsingFailed.title'),
            oxomi.translate('history.deeplinkParsingFailed.message')
        );
    });
}

Fixes: OX-9093

Previously this crashed hard. We now recover from the failure by ignoring the invalid parameter value. We additionally call a error handler callback function when defined so custom error handling logic can be executed.

Fixes: OX-9093
@sabieber sabieber added 🐛 Bugfix Contains only a small fix for an existing bug 👶🏻 Trivial Easy to review labels Sep 29, 2022
@sabieber sabieber merged commit c0bd795 into develop Sep 29, 2022
@sabieber sabieber deleted the feature/sbi/OX-9093 branch September 29, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bugfix Contains only a small fix for an existing bug 👶🏻 Trivial Easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants