Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revises Handling of ClosedChannelException (OX-9400/MIO-5896) #1143

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Revises Handling of ClosedChannelException (OX-9400/MIO-5896) #1143

merged 2 commits into from
Dec 9, 2022

Conversation

jakobvogel
Copy link
Member

andyHa added 2 commits December 9, 2022 15:29
@andyHa @jakobvogel
Also checks the cause of an exception when deciding about whether to …
8186385 
…ignore it 🤔

This is necessary as `JSONStructuredOutput` wraps a `ClosedChannelException` within a `HandledException` again. (See `JSONStructuredOutput.handleClosedChannel(ClosedChannelException)`.)

MIO-5896
OX-9400
@andyHa @jakobvogel
Removes superfluous catch clause 🧹
3ccf3c0 
The same logic is already available within `handleFailure(…)`.

MIO-5896
OX-9400
@jakobvogel jakobvogel merged commit 4e062ea into hotfix/ga-7.0.3 Dec 9, 2022
@jakobvogel jakobvogel deleted the feature/aha/MIO-5896-Channel-Closed branch December 9, 2022 14:58
@cschierle cschierle mentioned this pull request Dec 14, 2022
Merged
@cschierle cschierle mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyHa andyHa andyHa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobvogel @andyHa