Tycho: Prevents duplicate back navigation on page reload #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome has some weird behaviour where it completes running all code of the current execution context (everything that wasn't postponed by setTimeout or async calls). This introduced a bug in the tycho history handling where a reload on a job error page (and similar scenarios) would actually jump all the way back to the previously open page (e.g. the jobs overview page). We now use a simple flag to ensure the appendHistoryUrl logic does not get executed when we previously issued a back navigation in the on page load section of the history handling. Fixes: SIRI-716
Fixes: SIRI-716
andyHa
approved these changes
Mar 10, 2023
idlira
approved these changes
Mar 10, 2023
fhaScireum
approved these changes
Mar 10, 2023
mkeckmkeck
approved these changes
Mar 10, 2023
bkositza
approved these changes
Mar 10, 2023
jakobvogel
approved these changes
Mar 10, 2023
ymo-sci
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug scenario:
/system/jobsin a new tabPreviously working behaviour in FireFox:
Previously broken behaviour in Chrome:
Fixes: SIRI-716