Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes obsolete JSONPath class #1217

Merged
merged 3 commits into from
May 11, 2023
Merged

Conversation

sabieber
Copy link
Member

@sabieber sabieber commented May 11, 2023

BREAKING CHANGES:

  • Replace usages of JSONPath with Json::tryGetAt or other methods that take a JsonPointer

We now can utilize the much more capable JsonPointer API via our Json helper class.

Fixes: SIRI-736

We now can utilize the much more capable JsonPointer API via our Json helper class.

Fixes: SIRI-736
@sabieber sabieber added 👶🏻 Trivial Easy to review 💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code labels May 11, 2023
Fixes: SIRI-736
This is expected by the test (we want no error code in the response here).

Fixes: SIRI-736
@sabieber sabieber merged commit 087cea9 into develop May 11, 2023
@sabieber sabieber deleted the feature/sbi/remove-jsonpath branch May 11, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code 👶🏻 Trivial Easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants