Continuity: Prevents history change handling when back navigation is already queued #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome has some weird behaviour where it sometimes completes running all code of the current execution context (everything that wasn't postponed by setTimeout or async calls). This introduced a bug in the continuity history handling where a popStateEntry could actually be reverted automatically as the handleStateChange code ran after back navigation was intended and the back navigation and state change restore would cancel each other. We now use a simple flag to ensure the handleStateChange logic does not get executed when we previously issued a back navigation in popStateEntry. This is heavily inspired by commit 7c08942 which did the same in the tycho history logic. Fixes: OX-10192
sabieber
added
🐛 Bugfix
andyHa
approved these changes
Jul 7, 2023
src/main/resources/default/assets/common/scripts/continuity.js.pasta
Outdated
Show resolved
Hide resolved
idlira
approved these changes
Jul 7, 2023
mko-sci
approved these changes
Jul 7, 2023
mkeckmkeck
approved these changes
Jul 7, 2023
jakobvogel
approved these changes
Jul 7, 2023
fhaScireum
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome has some weird behaviour where it sometimes completes running all code of the current execution context (everything that wasn't postponed by setTimeout or async calls). This introduced a bug in the continuity history handling where a popStateEntry could actually be reverted automatically as the handleStateChange code ran after back navigation was intended and the back navigation and state change restore would cancel each other. We now use a simple flag to ensure the handleStateChange logic does not get executed when we previously issued a back navigation in popStateEntry.
This is heavily inspired by commit 7c08942 which did the same in the tycho history logic.
Fixes: OX-10192