Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decrease default sso-time to 4 hours #1282

Merged
merged 1 commit into from
Sep 6, 2023
Merged

decrease default sso-time to 4 hours #1282

merged 1 commit into from
Sep 6, 2023

Conversation

ymo-sci
Copy link
Contributor

@ymo-sci ymo-sci commented Aug 31, 2023

drive-by: fix typos

@ymo-sci ymo-sci added 👶🏻 Trivial Easy to review 🛠️ Maintenance Translations, Code Cleanup, ... labels Aug 31, 2023
jakobvogel
jakobvogel reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@jakobvogel jakobvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, in case of such a PR, I would love to have some reasoning about why this default value is changed. Just because the PR is trivial, the implications of it may not be. And, by the way, the typos should have been fixed in a separate commit.

jakobvogel
jakobvogel approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@jakobvogel jakobvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After explanation in MIO chat. For the future, please put in the information into the commit message, for long-time documentation.

@ymo-sci ymo-sci merged commit 2590d65 into develop Sep 6, 2023
@jakobvogel jakobvogel deleted the feature/ymo/sso branch September 20, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyHa andyHa andyHa approved these changes

@jmuscireum jmuscireum jmuscireum approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@mkeckmkeck mkeckmkeck mkeckmkeck approved these changes

@oolscireum oolscireum oolscireum approved these changes

@bkositza bkositza bkositza approved these changes

Assignees
No one assigned
Labels
🛠️ Maintenance Translations, Code Cleanup, ... 👶🏻 Trivial Easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ymo-sci @andyHa @jmuscireum @jakobvogel @fhaScireum @mkeckmkeck @oolscireum @bkositza