Tycho: Adds input addon with copy button #1289

sabieber · 2023-09-21T16:01:30Z

This allows to render an addon button next to a (most probably read-only) which copies the current value of the field into the clipboard on click.
It also updates the tooltip when this action worked.

Sample:

<t:textfield name="id"
             readonly="true"
             value="@token.getId()"
             label="ID"
             helpKey="PortalApiToken.id.help">
    <i:block name="addon">
        <t:copyToClipboardAddon fieldName="id"/>
    </i:block>
</t:textfield>

This is more flexible than just being able to show a simple text.

This is adapted from the OXOMI JS code base, so it should work in all modern browsers + IE 11.

This allows to render an addon button next to a (most probably read-only) which copies the current value of the field into the clipboard on click. It also updates the tooltip when this action worked.

jmuscireum · 2023-09-22T05:31:38Z

src/main/resources/default/assets/common/core.js.pasta

@@ -691,3 +691,64 @@ sirius.extractFileExtension = function (filename) {
    }
    return '.' + nameAndExtension.pop();
 }
+
+/**@


What does this solve that https://github.com/scireum/sirius-web/blob/develop/src/main/resources/default/assets/tycho/scripts/clipboard.js.pasta can't already do (except the scoping)?

Just my opinion:

Better scoping (along the other helper methods)

More robust fake element / fallback handling

Tried and tested code that ran a long time in OX (I can't find a call to the function from clipboard js)

Marking the element with a class (which is a required use case for OX

Actually I really didn't know the other function existed as it is nowhere used in sirius-web :D

sabieber added 3 commits September 21, 2023 17:32

Allows to inject a custom addon to text fields

30f1a1d

This is more flexible than just being able to show a simple text.

Adds a JS helper for reliably copying text to the clipboard

5122f0e

This is adapted from the OXOMI JS code base, so it should work in all modern browsers + IE 11.

Adds input addon with copy button

5cb80a7

This allows to render an addon button next to a (most probably read-only) which copies the current value of the field into the clipboard on click. It also updates the tooltip when this action worked.

sabieber added 🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review labels Sep 21, 2023

jakobvogel approved these changes Sep 21, 2023

View reviewed changes

mko-sci approved these changes Sep 21, 2023

View reviewed changes

jmuscireum reviewed Sep 22, 2023

View reviewed changes

mkeckmkeck approved these changes Sep 22, 2023

View reviewed changes

fhaScireum approved these changes Sep 22, 2023

View reviewed changes

jmuscireum approved these changes Sep 22, 2023

View reviewed changes

sabieber merged commit d64218f into develop Sep 22, 2023

sabieber deleted the feature/sbi/input-copy-addon branch September 22, 2023 08:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tycho: Adds input addon with copy button #1289

Tycho: Adds input addon with copy button #1289

sabieber commented Sep 21, 2023 •

edited

Loading

jmuscireum Sep 22, 2023

sabieber Sep 22, 2023 •

edited

Loading

Tycho: Adds input addon with copy button #1289

Tycho: Adds input addon with copy button #1289

Conversation

sabieber commented Sep 21, 2023 • edited Loading

jmuscireum Sep 22, 2023

Choose a reason for hiding this comment

sabieber Sep 22, 2023 • edited Loading

Choose a reason for hiding this comment

sabieber commented Sep 21, 2023 •

edited

Loading

sabieber Sep 22, 2023 •

edited

Loading