JUNIT: Migrate assets dispatcher test to Kotlin #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mko-sci
approved these changes
Dec 7, 2023
mkeckmkeck
approved these changes
Dec 7, 2023
Comment on lines
19
to
21
| // Setting the "Origin: header" must be allowed by -Dsun.net.http.allowRestrictedHeaders=true | ||
| HttpURLConnection c = new URL("http://localhost:9999/system/ok").openConnection() | ||
| c.addRequestProperty("Origin", "TEST") |
There was a problem hiding this comment.
Suggested change
| // Setting the "Origin: header" must be allowed by -Dsun.net.http.allowRestrictedHeaders=true | |
| HttpURLConnection c = new URL("http://localhost:9999/system/ok").openConnection() | |
| c.addRequestProperty("Origin", "TEST") | |
| HttpURLConnection c = new URL("http://localhost:9999/system/ok").openConnection() | |
| // Setting the "Origin" header must be allowed by system property sun.net.http.allowRestrictedHeaders=true | |
| c.addRequestProperty("Origin", "TEST") |
sabieber
approved these changes
Dec 7, 2023
| @@ -16,8 +16,7 @@ class CORSSpec extends BaseSpecification { | |||
|
|
|||
| def "expect 'Access-Control-Allow-Origin' for requests with 'origin'"() { | |||
| when: | |||
| // Allow us to set the Origin: header... | |||
| System.setProperty("sun.net.http.allowRestrictedHeaders", "true") | |||
| // Setting the "Origin: header" must be allowed by -Dsun.net.http.allowRestrictedHeaders=true | |||
| HttpURLConnection c = new URL("http://localhost:9999/system/ok").openConnection() | |||
There was a problem hiding this comment.
Optional: Rename c to connection
| fun `proper caching set for all kind of assets and cache-control URIs`(uri: String, header: String) { | ||
| val connection = URL("http://localhost:9999" + uri).openConnection() | ||
| assertEquals(header, connection.getHeaderField(HttpHeaderNames.CACHE_CONTROL.toString())) | ||
|
|
idlira
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.