-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortens encoded deeplink URL parameter value #1444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by not mixing up integer char representations between 8 and 16 bit This mixup lead to our deeplinks being two times as long as necessary while containing the same information. As we used inverse logic for encoding and decoding this did not lead to any problems. Fixes: SIRI-987
Fixes: SIRI-987
mkeckmkeck
approved these changes
Jul 16, 2024
fhaScireum
approved these changes
Jul 16, 2024
jakobvogel
approved these changes
Jul 16, 2024
idlira
approved these changes
Jul 16, 2024
mko-sci
approved these changes
Jul 16, 2024
After some feedback and local testing the encoding/decoding logic can be further simplified and still encodes and decodes the JSON state string correctly and reliably. Fixes: SIRI-987
Fixes: SIRI-987
scireum-mbo
approved these changes
Jul 17, 2024
jakobvogel
approved these changes
Jul 17, 2024
idlira
approved these changes
Jul 17, 2024
mkeckmkeck
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
... by not mixing up integer char representations between 8 and 16 bit
This mixup lead to our deeplinks being two times as long as necessary while containing the same information.
As we used inverse logic for encoding and decoding this did not lead to any problems.
Deeplinks in the old format are still correctly read and "converted".
Before:
After:
--> URL decoded:
--> Base64 decoded:
Additional Notes
Checklist