Core JS - Allow to send POST data as urlencoded instead of multipart form data #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netty seems to replace some characters like commas, colons, semicolons, ... with spaces when reading the multipart form data in `HttpPostMultipartRequestDecoder::getContentDispositionAttribute`. This may be problematic when trying to match the parameter names to data. To circumvent this in a non breaking fashion we add a new optional parameter that converts the FormData into an URLSearchParams object. This way data is sent with content type `application/x-www-form-urlencoded` instead of `multipart/form-data`. Fixes: OX-10757
scireum-mbo
approved these changes
Aug 27, 2024
idlira
approved these changes
Aug 27, 2024
jmuscireum
approved these changes
Aug 27, 2024
jakobvogel
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Netty seems to replace some characters like commas, colons, semicolons, ... with spaces when reading the multipart form data in
HttpPostMultipartRequestDecoder::getContentDispositionAttribute. This may be problematic when trying to match the parameter names to data.To circumvent this in a non breaking fashion we add a new optional parameter that converts the FormData into an URLSearchParams object. This way data is sent with content type
application/x-www-form-urlencodedinstead ofmultipart/form-data.see:
https://github.com/netty/netty/blob/4.1/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java#L875
https://github.com/netty/netty/blob/4.1/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java#L1293
Additional Notes
Checklist