Returns the oauth access token "expires at" date #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in case the server did return it Fixes: SE-13502
mkeckmkeck
added
💣 BREAKING CHANGE
sabieber
approved these changes
Sep 4, 2024
jakobvogel
reviewed
Sep 4, 2024
- as per RFC the containing field is optional - the accessTokenExpiresAt is not strictly required by our implementations as well - so make it null in case it cannot be determined from server response Fixes: SE-13502
jakobvogel
approved these changes
Sep 4, 2024
sabieber
approved these changes
Sep 4, 2024
jmuscireum
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Returns the oauth access token "expires at" date in case the server did return it.
Providing this information e.g. gives the API caller the possibility to refresh the token if required. The usage is optional, if not set, the implemention in sirius will trigger a refresh if the provided access token could not be used to authenticate at server.
Technically this is breaking. But it should have no impact on API users as only the framework should use the constructor with the changed parameters.
Additional Notes
Checklist