-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds components for a selectable table #1468
Conversation
Fixes: OX-11093
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grey of selected lines in the screenshot looks a bit too dark (contrast!)
Its a bit brighter than the hover effect in reality. |
The hover effect can be terminated by just moving the mouse. Your highlighting requires to undo the selection if the color contrast is bad. Please make sure that the color choice is sufficient in terms of accessibility requirements. |
I don't really like the grey in general, as it clashes with the hover effect and the striped-table-mode. |
src/main/resources/default/assets/tycho/scripts/selectableTable.js.pasta
Outdated
Show resolved
Hide resolved
src/main/resources/default/assets/tycho/scripts/selectableTable.js.pasta
Outdated
Show resolved
Hide resolved
src/main/resources/default/assets/tycho/scripts/selectableTable.js.pasta
Outdated
Show resolved
Hide resolved
src/main/resources/default/assets/tycho/scripts/selectableTable.js.pasta
Outdated
Show resolved
Hide resolved
…ility Fixes: OX-11093
Fixes: OX-11093
Fixes: OX-11093
Hmm, because it is more desaturated than the others. I think @sabieber was referring to pastel-like colors, like the blue used by Apple for text selections, or by MIO for the background of the green conversation tags, etc. |
- Improves the visibility for striped tables. - We already use a lot of gray for hovering, row separation and the striped mode Fixes: OX-11093
Co-authored-by: Matthias Keck <60612914+mkeckmkeck@users.noreply.github.com>
Description
Table when nothing is selected:
Multiple rows are selected:
All rows are selected:
Behavior:
thead
will be checked as well.Additional Notes
Checklist