Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds components for a selectable table #1468

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Conversation

mko-sci
Copy link
Contributor

@mko-sci mko-sci commented Oct 22, 2024

Description

Table when nothing is selected:
Bildschirmfoto 2024-10-22 um 15 43 17

Multiple rows are selected:
Bildschirmfoto 2024-10-22 um 15 43 34

All rows are selected:
Bildschirmfoto 2024-10-22 um 15 43 54

Behavior:

  • if the "select-all-checkbox" is being clicked on, all rows are checked.
  • if all rows are checked, the "select-all-checkbox" in the thead will be checked as well.
  • if all rows are checked and the "select-all-checkbox" is checked, all rows will be unselected.
  • if all rows are checked and one row gets unchecked, the "select-all-checkbox" is unchecked.
  • rows can be checked by either clicking on the checkbox or on the row.
    • Note: Clicking on links and buttons wont trigger the row selection

Additional Notes

  • This PR fixes or works on following ticket(s): OX-11093

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices

@mko-sci mko-sci added the 🧬 Enhancement Contains new features label Oct 22, 2024
Copy link
Member

@jakobvogel jakobvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grey of selected lines in the screenshot looks a bit too dark (contrast!)

@mko-sci
Copy link
Contributor Author

mko-sci commented Oct 22, 2024

The grey of selected lines in the screenshot looks a bit too dark (contrast!)

Its a bit brighter than the hover effect in reality.

@jakobvogel
Copy link
Member

The grey of selected lines in the screenshot looks a bit too dark (contrast!)

Its a bit brighter than the hover effect in reality.

The hover effect can be terminated by just moving the mouse. Your highlighting requires to undo the selection if the color contrast is bad. Please make sure that the color choice is sufficient in terms of accessibility requirements.

@sabieber
Copy link
Member

The grey of selected lines in the screenshot looks a bit too dark (contrast!)

I don't really like the grey in general, as it clashes with the hover effect and the striped-table-mode.
Maybe a very soft blue or some other highlight entirely would be better suited.

@mko-sci
Copy link
Contributor Author

mko-sci commented Oct 23, 2024

bg-sirius-cyan:

Bildschirmfoto 2024-10-23 um 10 19 37

bg-sirius-cyan-light:
Bildschirmfoto 2024-10-23 um 10 24 17

bg-sirius-blue-light:
Bildschirmfoto 2024-10-23 um 10 20 21

bg-sirius-gray-light:
Bildschirmfoto 2024-10-23 um 10 21 57

bg-sirius-gray-lighter:
Bildschirmfoto 2024-10-23 um 10 23 02

IMHO: bg-sirius-gray-lighter fits the best!

Fixes: OX-11093
@jakobvogel
Copy link
Member

IMHO: bg-sirius-gray-lighter fits the best!

Hmm, because it is more desaturated than the others. I think @sabieber was referring to pastel-like colors, like the blue used by Apple for text selections, or by MIO for the background of the green conversation tags, etc.

- Improves the visibility for striped tables.
- We already use a lot of gray for hovering, row separation and the striped mode

Fixes: OX-11093
@mko-sci
Copy link
Contributor Author

mko-sci commented Oct 23, 2024

bg-sirius-blue-faint:

Bildschirmfoto 2024-10-23 um 10 53 10

@mko-sci mko-sci requested a review from sabieber October 23, 2024 08:53
Co-authored-by: Matthias Keck <60612914+mkeckmkeck@users.noreply.github.com>
@mko-sci mko-sci merged commit acc8c0b into develop Oct 23, 2024
3 checks passed
@mko-sci mko-sci deleted the feature/mko/OX-11093 branch October 23, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧬 Enhancement Contains new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants