Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the use of URLSearchParams and String in sirius.postJson #1478

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Support the use of URLSearchParams and String in sirius.postJson #1478

merged 4 commits into from
Nov 18, 2024

Conversation

jmuscireum
Copy link
Contributor

@jmuscireum jmuscireum commented Nov 18, 2024 •
edited
Loading

Description

This allows the use of URLSearchParams and String as the 'params' parameter in sirius.postJson, which sometimes are easier to build than an object.

The second commit allows URLSearchParams in the fetch polyfill.

Additional Notes

  • This PR fixes or works on following ticket(s): SE-14122

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@jmuscireum
Support the use of URLSearchParams and String in sirius.postJson
07106e5 
This allows the use of URLSearchParams and String as the 'params' parameter in sirius.postJson, which sometimes are easier to build that an object.

Fixes: SE-14122
@jmuscireum
Support URLSearchParams in the IE11 fetch polyfill
26c7de7 
This simply changes the include order to make URLSearchParams known to the fetch polyfill.

Fixes: SE-14122
@jmuscireum
Improve JavaDoc
aeae2b5 
Fixes: SE-14122
@jmuscireum jmuscireum added the 🧬 Enhancement Contains new features label Nov 18, 2024
@jmuscireum jmuscireum merged commit 5babe94 into develop Nov 18, 2024
3 checks passed
@jmuscireum jmuscireum deleted the feature/jmu/SE-14122-postJson-parameters branch November 18, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mko-sci mko-sci mko-sci approved these changes

@idlira idlira idlira approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmuscireum @sabieber @jakobvogel @idlira @mko-sci