Prevents the row from being selected when clicked on an i-tag #1480
Conversation
Fixes: OX-11094
mko-sci
added
🐛 Bugfix
| if (event.target.tagName.toLowerCase() !== 'input' && | ||
| event.target.tagName.toLowerCase() !== 'a' && | ||
| event.target.tagName.toLowerCase() !== 'i' && | ||
| event.target.tagName.toLowerCase() !== 'button') { |
There was a problem hiding this comment.
Wouldn't it be better to maintain a whitelist or use a marker class that possible click-targets get assigned?
There was a problem hiding this comment.
Also, it would be nice to know why particularly <i> tags in particular are supposed to be exempt? Why not <b> tags? Or <span> tags? To me, the entire PR lacks justification. (Not saying that it is not justified, but there is no reasoning.)
There was a problem hiding this comment.
Icons are often wrapped in <i>-tags. If you add an <a> which has an <i> inside and you manage to click directly on the <i> (or the icon) you would select the row. In this case however the intention was to click on the <a>-button.
There was a problem hiding this comment.
Wouldn't it be better to maintain a whitelist or use a marker class that possible click-targets get assigned?
I see what you mean. I will look into it if I have spare time if thats ok for you.
There was a problem hiding this comment.
Icons are often wrapped in
<i>-tags. If you add an<a>which has an<i>inside and you manage to click directly on the<i>(or the icon) you would select the row. In this case however the intention was to click on the<a>-button.
In case of FA, the <i> tag only serves as a marker and is replaced by a <svg> tag if i am not wrong.
|
Merged because This PR just extends the current mechanism. Obvoiusly we need to rework the mechansim but there is currently no time for that since we are close the release. |
Additional Notes
Checklist