Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design System additions #1495

Merged
merged 14 commits into from
Jan 15, 2025
Merged

Design System additions #1495

merged 14 commits into from
Jan 15, 2025

Conversation

jmuscireum
Copy link
Contributor

@jmuscireum jmuscireum commented Jan 15, 2025 •
edited
Loading

Description

This adds additional classes to the scireum Design System.

Breaking

Uses of --sci-margin-05 need to be replaced with --sci-margin-0_5.

Additional Notes

  • This PR fixes or works on following ticket(s): SE-13735

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@jmuscireum
Design System: Add more margin and padding classes
61650b0 
Fixes: SE-13735
@jmuscireum
Design System: Introduce gap classes
a4ffa72 
Fixes: SE-13735
@jmuscireum
Design System: Add more border classes
2ef9c75 
Fixes: SE-13735
@jmuscireum
Design System: Add more display classes
51c76b2 
Fixes: SE-13735
@jmuscireum
Design System: Add another align-items class
4094b5f 
Fixes: SE-13735
@jmuscireum
Design System: Add more text classes
6a3f5eb 
Fixes: SE-13735
@jmuscireum
Design System: Add a class for a sticky last table column
c72d4f0 
Fixes: SE-13735
@jmuscireum
Design System: Prevent pointer-events on buttons with sci-btn-disabled
b0f161b 
Fixes: SE-13735
@jmuscireum
Design System: Add a class for interactive elements inside sci-stretc…
becc6ce 
…hed-link

This can for example be used for buttons inside a clickable sci-card.

Fixes: SE-13735
@jmuscireum
Design System: Fix the font-size inside sci-text-input
136a07a 
Fixes: SE-13735
@jmuscireum jmuscireum added the 🧬 Enhancement Contains new features label Jan 15, 2025
sabieber
sabieber approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@sabieber sabieber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👌🏻 Think this will increase our flexibility for future expansions

src/main/resources/assets/design-system/margin-padding.scss Outdated Show resolved Hide resolved
@jmuscireum
Design System: Remove the --sci-margin-05 variable
4d8dadb 
This is breaking as used need to be replaced with --sci-margin-0_5

Fixes: SE-13735
@jmuscireum jmuscireum added the 💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code label Jan 15, 2025
@jmuscireum jmuscireum merged commit dc14f2b into develop Jan 15, 2025
4 checks passed
@jmuscireum jmuscireum deleted the feature/jmu/SE-13735-design-system-additions branch January 15, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@idlira idlira idlira approved these changes

@mko-sci mko-sci mko-sci approved these changes

@scireum-mbo scireum-mbo scireum-mbo approved these changes

Assignees
No one assigned
Labels
💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code 🧬 Enhancement Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmuscireum @sabieber @jakobvogel @idlira @mko-sci @scireum-mbo