Adds multiple icon classes and allows changing the color #1508
Conversation
Fixes: OX-11901
| } | ||
|
|
||
| .sci-icon-bars-blue { | ||
| background-image: url(svgResource('/assets/images/icons/fontawesome/bars.svg', #3465CC)); |
There was a problem hiding this comment.
I see that we use the explicit color code elsewhere as well – but do we need to? Is there no matching colour in the palette of predefined colours? If not, why do we need particularly that blue here then?
There was a problem hiding this comment.
Thats exactly what I thought, but no - there is no predefined color for the blue - and also when you take a look into the file - there are a lot of custom colors in there already.
I am wondering why we even started with the sirius-colors when no one really cares..
There was a problem hiding this comment.
If not, why do we need particularly that blue here then?
I dont know - its the blue we use in OX within the Datasheet and Infoplay dialogs and other places aswell...
There was a problem hiding this comment.
$sirius-primary looks close enough, doesn't it? – if we want to port OX to use that color as well, of course
There was a problem hiding this comment.
yup - but I think this should be done in a separate ticket - especially since we would neet to change a lot of places in OX as well
There was a problem hiding this comment.
@mko-sci Will you create a ticket for this?
Description
These icons are used in the new OX-Watchlist feature.
Additional Notes
Checklist