Do not add Messages from MessageProviders to List in UserContext #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or else the Messages of the MessageProvider and MaintenanceInfo will be added to the list everytime "public List<Message> getMessages()" is called, and therefore will be in the list multiple times if the method is called multiple times.
andyHa
reviewed
Jun 19, 2019
| getScope().tryAs(MessageProvider.class).ifPresent(provider -> provider.addMessages(messages::add)); | ||
| getUser().tryAs(MessageProvider.class).ifPresent(provider -> provider.addMessages(messages::add)); | ||
| messageProviders.forEach(provider -> provider.addMessages(messages::add)); | ||
| return messages; | ||
| } | ||
|
|
||
| return msgList; |
andyHa
reviewed
Jun 19, 2019
| getScope().tryAs(MessageProvider.class).ifPresent(provider -> provider.addMessages(messages::add)); | ||
| getUser().tryAs(MessageProvider.class).ifPresent(provider -> provider.addMessages(messages::add)); | ||
| messageProviders.forEach(provider -> provider.addMessages(messages::add)); | ||
| return messages; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or else the Messages of the MessageProvider and MaintenanceInfo will be added to the list everytime "public List getMessages()" is called, and therefore will be in the list multiple times if the method is called multiple times.
Messages where displayed twice, because sirius-biz calls "validate" which calls "getMessages()", when displaying a tenant, so "getMessages()" was called twice.
https://github.com/scireum/sirius-biz/blob/master/src/main/java/sirius/biz/tenants/TenantController.java#L145