The enabled/disabled check is now applied after expression parsing #839
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2021 16:02
…on parsing This means, that 'enabled' and 'disabled' can be used as part of a permission expression. For example: 'a+enabled,!disabled+b' works now as expected and is equivalent to 'a,b'
sabieber
approved these changes
May 11, 2021
mkeckmkeck
approved these changes
May 11, 2021
ymo-sci
approved these changes
May 12, 2021
fgoerner
approved these changes
May 12, 2021
andyHa
approved these changes
May 12, 2021
fhaScireum
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means, that 'enabled' and 'disabled' can be used as part of a permission expression.
For example: 'a+enabled,!disabled+b' works now as expected and is equivalent to 'a,b'