Further improves the Facet API and ReportBrokenTemplates #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andyHa
commented
Jun 16, 2021
andyHa
commented
- Removes / simplifies some methods in Facet
- Only checks local templates and not ones brought in by dependencies.
There is no point in providing the value, as this is automatically set using withValue(s) once it is bound to a WebContext. Also a value translator isn't always required and hence moved into its own method to provide one.
ymo-sci
reviewed
Jun 16, 2021
Co-authored-by: Yannick Möller <55080004+ymo-sci@users.noreply.github.com>
idlira
approved these changes
Jun 16, 2021
sabieber
approved these changes
Jun 16, 2021
jmuscireum
approved these changes
Jun 16, 2021
cschierle
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.